Yedidyah Bar David has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 4:
(2 comments)
....................................................
File packaging/bin/engine-backup.sh
Line 211: log "Verifying connection"
Line 212: verifyConnection
Line 213: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 214: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 215: if [ "${START_SERVICES}" = 1 ]; then
Well, don't know why, didn't work for me. I definitely waited more than 5
seconds.
Line 216: #TODO: Do this at all?
Line 217: output "Starting services:"
Line 218: service ovirt-engine start || die "Failed to start
engine service"
Line 219: service httpd restart || logdie "Failed to restart
httpd"
Line 215: if [ "${START_SERVICES}" = 1 ]; then
Line 216: #TODO: Do this at all?
Line 217: output "Starting services:"
Line 218: service ovirt-engine start || die "Failed to start
engine service"
Line 219: service httpd restart || logdie "Failed to restart
httpd"
Yes, but if it was down, a restart will start it. That's intrusive too, and, by
your logic, should be opt in.
Line 220: fi
Line 221: output "Note: you might need to manually fix:"
Line 222: output "- iptables/firewalld configuration"
Line 223: output "- autostart of ovirt-engine service"
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
