Alon Bar-Lev has posted comments on this change.
Change subject: packaging: gluster:Hide irrelevant fields in configuration
preview during setup
......................................................................
Patch Set 6:
ok, for the storage type we have a problem as we do set the storage type within
application as it won't work without, see:
packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py
if self.environment[
osetupcons.ConfigEnv.APPLICATION_MODE
] == 'gluster':
self.environment[
osetupcons.ConfigEnv.STORAGE_TYPE
] = osetupcons.Defaults.DEFAULT_CONFIG_STORAGE_TYPE.lower()
so we actually set it, why is there a reason to hide it?
maybe make sure that we can just put 'gluster' there and application ignores
it? then there is no problem in either hide or just print it.
--
To view, visit http://gerrit.ovirt.org/20955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
