Kanagaraj M has posted comments on this change.
Change subject: engine: Clean up orphan gluster task references
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 97: {
Line 98: return null;
Line 99: }
Line 100:
Line 101: Map<Guid, GlusterAsyncTask> runningTasks =
getProvider().getTaskListForCluster(cluster.getId());
This line can be moved to the above method, so that it will look more cleaner
as follows
if(runningTasks != null) {
updateTasksInCluster(cluster, runningTasks)
tasksFromClusters.addAll(runningTasks.keySet());
}
Line 102:
Line 103: if (runningTasks == null) {
Line 104: return null;
Line 105: }
Line 378: List<Step> steps =
getStepDao().getStepsByExternalId(taskId);
Line 379: for (Step step: steps) {
Line 380: step.markStepEnded(JobExecutionStatus.UNKNOWN);
Line 381: endStepJob(step);
Line 382: }
What will happen if the TaskList is failed due to glusterd crash or something
else?
Line 383: releaseVolumeLock(taskId);
Line 384: }
Line 385:
Line 386: }
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
