Kanagaraj M has posted comments on this change.
Change subject: engine: Clean up orphan gluster task references
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 143: }
Line 144:
Line 145:
Line 146: }
Line 147:
no need to return, it is same as passed in the arg
Line 148: return runningTasks;
Line 149: }
Line 150:
Line 151:
Line 357:
Line 358: private void cleanUpOrphanTasks(List<Guid> runningTasksinCluster)
{
Line 359: //Populate the list of tasks that need to be monitored from
database
Line 360: List<Guid> taskListInDB =
getProvider().getMonitoredTaskIDsInDB();
Line 361: if (taskListInDB == null) {
also check for empty as well
if (taskListInDB == null || taskListInDB.isEmpty()) {
return
}
Line 362: return;
Line 363: }
Line 364:
Line 365: //if task is in DB but not in running task list
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
