Sahina Bose has posted comments on this change.
Change subject: engine: Clean up orphan gluster task references
......................................................................
Patch Set 3:
(2 comments)
Patchset to follow
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 89: Map<Guid, GlusterAsyncTask> runningTasks =
getProvider().getTaskListForCluster(cluster.getId());
Line 90: if (runningTasks != null) {
Line 91: updateTasksInCluster(cluster, runningTasks);
Line 92: tasksFromClusters.addAll(runningTasks.keySet());
Line 93: }
Good point. Changing the getTaskListForCluster to throw a VdcBllException in
this case as well
Line 94: } catch (VdcBLLException e) {
Line 95: cleanOrphanTasks = false;
Line 96: }
Line 97: }
Line 358: private void cleanUpOrphanTasks(List<Guid> runningTasksinCluster)
{
Line 359: //Populate the list of tasks that need to be monitored from
database
Line 360: List<Guid> taskListInDB =
getProvider().getMonitoredTaskIDsInDB();
Line 361: if (taskListInDB == null) {
Line 362: taskListInDB = new ArrayList<Guid>();
Done
Line 363: }
Line 364:
Line 365: //if task is in DB but not in running task list
Line 366: final Set<Guid> tasksNotRunning = new
HashSet<Guid>(taskListInDB);
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
