Lior Vernia has posted comments on this change. Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab ......................................................................
Patch Set 6: Code-Review+1 (1 comment) This looks good to me as ValueLabel<String>(new StringRenderer()) ultimately handles strings the same as TextBoxLabel. However, since TextBoxLabel is used all over the project it makes me wonder if perhaps I'm missing something. Maybe Vojtech would care to comment? .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java Line 46 Line 47 Line 48 Line 49 Line 50 I don't see any need to remove this empty line, it might be nice to have it separate the private final "non-interesting" members from the UI fields. -- To view, visit http://gerrit.ovirt.org/20964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
