anmolbabu has posted comments on this change.
Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab
......................................................................
Patch Set 7:
> we should make sure that text inside the 'General' sub-tab is
> copy-paste-able, therefore, I believe that we should replace everything to
> use TextBoxLabel, rather than ValueLabel.
Thanks.
Hi,But changing everything to
"TextBoxLabel(extending from
TextBox --> TextBoxBase --> ValueBoxBase<String>
)"
requires all its respective getters to return string and hence creates problems
in case of other types like,
rpmversion -- libvirtVersion
long -- swapTotal
boolean -- memoryPageSharing
--
To view, visit http://gerrit.ovirt.org/20964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
