Vojtech Szocs has posted comments on this change. Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab ......................................................................
Patch Set 6: (1 comment) > This looks good to me as ValueLabel<String>(new StringRenderer()) ultimately > handles strings the same as TextBoxLabel. However, since TextBoxLabel is used > all over the project it makes me wonder if perhaps I'm missing something. > Maybe Vojtech would care to comment? Well, TextBoxLabel renders border-less <input type="text" readonly> element and ValueLabel renders (in this case) <span> element. It's not a big deal, however I recall we used to prefer TextBoxLabel in "General" sub-tabs for consistency, i.e. TextBoxLabel has the ability to copy value easily via right-click so that <input> gains focus and selects everything inside. Einav, what do you think? Note: we also use ValueLabel either directly or indirectly (custom subclasses - BooleanLabel, ClusterTypeLabel, etc.) in some other "General" sub-tabs. .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java Line 46 Line 47 Line 48 Line 49 Line 50 +1 -- To view, visit http://gerrit.ovirt.org/20964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
