Alon Bar-Lev has posted comments on this change.
Change subject: utils: pki-resource: cleanup: levarage enum for constants
......................................................................
Patch Set 7:
1. I can delegate this to format, but then I need a function per enum anyway...
probably initialize function pointer within the enum element initialization, it
looked complex...
enum {
X509_PEM_CA("content-type", function-pointer),
private String function-pointer(certificate) {
}
}
and I thought this will be even more complex, as these two enums are part of
the same class it does not matter if I delegate it to output or not.
2. the alias is default alias for a resource, it is part of the resource.
--
To view, visit http://gerrit.ovirt.org/21073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
