Allon Mureinik has posted comments on this change.
Change subject: engine: Disk interface validation
......................................................................
Patch Set 7:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java
Line 33: getParameters().getVmId(),
Line 34: getUserID(),
Line 35: getParameters().isFiltered());
Line 36: if (CollectionUtils.isEmpty(diskList)) {
Line 37: setReturnValue(Collections.emptyList());
I'm not sure if this can't cause problems with GWT later on.
I'd set the return value to "diskList" if it's empty.
Line 38: return;
Line 39: }
Line 40:
Line 41: VM vm =
DbFacade.getInstance().getVmDao().get(getParameters().getVmId(),
Line 41: VM vm =
DbFacade.getInstance().getVmDao().get(getParameters().getVmId(),
Line 42: getUserID(),
Line 43: getParameters().isFiltered());
Line 44: if (vm == null) {
Line 45: setReturnValue(Collections.emptyList());
see comment above.
You probably need to use new ArrayList<>()
Line 46: return;
Line 47: }
Line 48:
Line 49: List<String> supportedDiskInterfaceNames =
getOsRepository().getDiskInterfaces(vm.getOs(),
Line 69:
Line 70: setReturnValue(filteredDiskList);
Line 71: }
Line 72:
Line 73: public OsRepository getOsRepository() {
I'd make this protected.
Line 74: return
SimpleDependecyInjector.getInstance().get(OsRepository.class);
Line 75: }
Line 76:
--
To view, visit http://gerrit.ovirt.org/18648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
