Sergey Gotliv has posted comments on this change.
Change subject: engine: Disk interface validation
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java
Line 26: getParameters().getVmId(),
Line 27: getUserID(),
Line 28: getParameters().isFiltered());
Line 29: if (CollectionUtils.isEmpty(diskList)) {
Line 30: setReturnValue(new ArrayList<>());
I beleive that @Allon in his comment on the previous patch set wanted to return
"diskList" here, currently it looks like unnecessary creating of the new array.
Line 31: return;
Line 32: }
Line 33:
Line 34: VM vm =
DbFacade.getInstance().getVmDao().get(getParameters().getVmId(),
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 158: DiskValidator diskValidator = getDiskValidator(getNewDisk());
Line 159: return validateCanUpdateShareable() &&
validateCanUpdateReadOnly() &&
Line 160: validate(diskValidator.isVirtIoScsiValid(getVm())) &&
Line 161: (getOldDisk().getDiskInterface() ==
getNewDisk().getDiskInterface()
Line 162: ||
validate(diskValidator.isDiskInterfaceSupported(getVm())));
Nice move!
Line 163: }
Line 164:
Line 165: @Override
Line 166: protected void setActionMessageParameters() {
--
To view, visit http://gerrit.ovirt.org/18648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
