Allon Mureinik has posted comments on this change.
Change subject: engine: Disk interface validation
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Looks good to me.
I'd like Roy's input on the use of OS Repository, just to be on the safe side.
Giving +1 until Roy takes a look, if it's OK with him, I'll upgrade to +2.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java
Line 26: getParameters().getVmId(),
Line 27: getUserID(),
Line 28: getParameters().isFiltered());
Line 29: if (CollectionUtils.isEmpty(diskList)) {
Line 30: setReturnValue(new ArrayList<>());
Actually, a new ArrayList<> seems better. The result has to be serializable for
GWT compatibility, and and we don't want to enforce such a dependency on the
DAO layer.
Line 31: return;
Line 32: }
Line 33:
Line 34: VM vm =
DbFacade.getInstance().getVmDao().get(getParameters().getVmId(),
Line 38: setReturnValue(new ArrayList<>());
Line 39: return;
Line 40: }
Line 41:
Line 42: List<Disk> filteredDiskList = new ArrayList<Disk>();
nit: new ArrayList<>();
Line 43: for (Disk disk : diskList) {
Line 44: if
(DiskValidator.isDiskInterfaceSupportedByOs(disk.getDiskInterface(),
Line 45: vm.getOs(), vm.getVdsGroupCompatibilityVersion()))
{
Line 46: filteredDiskList.add(disk);
--
To view, visit http://gerrit.ovirt.org/18648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
