Allon Mureinik has posted comments on this change.
Change subject: engine: Disk interface validation
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Makes sense to me (see a couple of nits inline).
@Roy - can we proceed with this?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
Line 130: * @param osId - OS id
Line 131: * @param version - Version
Line 132: * @return
Line 133: */
Line 134: public static boolean isDiskInterfaceSupportedByOs(DiskInterface
diskInterface, int osId, Version version) {
should probably be private
Line 135: return getOsRepository().getDiskInterfaces(osId,
version).contains(diskInterface.name());
Line 136: }
Line 137:
Line 138: public static OsRepository getOsRepository() {
Line 134: public static boolean isDiskInterfaceSupportedByOs(DiskInterface
diskInterface, int osId, Version version) {
Line 135: return getOsRepository().getDiskInterfaces(osId,
version).contains(diskInterface.name());
Line 136: }
Line 137:
Line 138: public static OsRepository getOsRepository() {
This too
Line 139: return
SimpleDependecyInjector.getInstance().get(OsRepository.class);
Line 140: }
--
To view, visit http://gerrit.ovirt.org/18648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
