Maor Lipchuk has posted comments on this change.
Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java
Line 50: public void setStoragePoolId(Guid storagePoolId) {
Line 51: this.storagePoolId = storagePoolId;
Line 52: }
Line 53:
Line 54: @Size(min = 1, max = 50, message =
"VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH",
Please declare length at BusinessEntitiesDefinitions.
BTW I think that you don't have to create a new message but to use the default
message of Size annotation : " size must be between {min} and {max}"
Line 55: groups = { CreateEntity.class, UpdateEntity.class })
Line 56: @ValidI18NName(message =
"VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER",
Line 57: groups = { CreateEntity.class, UpdateEntity.class })
Line 58: public String getName() {
Line 63: this.name = name;
Line 64: }
Line 65:
Line 66: @ValidDescription(message =
"VALIDATION.ISCSI_BOND.DESCRIPTION.INVALID",
Line 67: groups = { CreateEntity.class, UpdateEntity.class })
What about max length validation?
Line 68: public String getDescription() {
Line 69: return description;
Line 70: }
Line 71:
--
To view, visit http://gerrit.ovirt.org/22951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
