Maor Lipchuk has posted comments on this change.
Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao
......................................................................
Patch Set 4:
(3 comments)
please add DAO tests
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java
Line 103: int result = 1;
Line 104: result = prime * result + ((id == null) ? 0 : id.hashCode());
Line 105: result = prime * result + ((name == null) ? 0 :
name.hashCode());
Line 106: result = prime * result + ((description == null) ? 0 :
description.hashCode());
Line 107: return result;
What about storage pool id?
Line 108: }
Line 109:
Line 110: @Override
Line 111: public boolean equals(Object obj) {
Line 119:
Line 120: IscsiBond iscsiBond = (IscsiBond) obj;
Line 121: return ObjectUtils.objectsEqual(id, iscsiBond.getId()) &&
Line 122: ObjectUtils.objectsEqual(name, iscsiBond.getName()) &&
Line 123: ObjectUtils.objectsEqual(description,
iscsiBond.getDescription());
what about storage pool id?
Line 124: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/IscsiBondDaoDbFacadeImpl.java
Line 25: }
Line 26:
Line 27: @Override
Line 28: public List<Guid> getNetworkIdsByIscsiBondId(Guid iscsiBondId) {
Line 29: return
getCallsHandler().executeReadList("GetNetworksByIscsiBondId", new
RowMapper<Guid>() {
Same question as in last patchset why not using IscsiBondRowMapper.instance?
Line 30: @Override
Line 31: public Guid mapRow(ResultSet rs, int index) throws
SQLException {
Line 32: return new Guid((UUID) rs.getObject(1));
Line 33: }
--
To view, visit http://gerrit.ovirt.org/22951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
