Maor Lipchuk has posted comments on this change.
Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao
......................................................................
Patch Set 3:
(5 comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 1087:
Line 1088: SCHEDULING_ALL_HOSTS_FILTERED_OUT=Cannot ${action} ${type}. There is
no host that satisfies current scheduling constraints. See bellow for details:
Line 1089: SCHEDULING_HOST_FILTERED_REASON=The host ${hostName} did not satisfy
${filterType} filter ${filterName}.
Line 1090: VAR__FILTERTYPE__EXTERNAL=$filterType external
Line 1091: VAR__FILTERTYPE__INTERNAL=$filterType internal
What about all the rest of the properties file? What about AppErrors.java?
Line 1092: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform
${action}. Another power management action is already in progress.
Line 1093:
Line 1094: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be
formed from alpha-numeric characters or "-_."
Line 1095: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be
between {1} and {2}
Line 1090: VAR__FILTERTYPE__EXTERNAL=$filterType external
Line 1091: VAR__FILTERTYPE__INTERNAL=$filterType internal
Line 1092: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform
${action}. Another power management action is already in progress.
Line 1093:
Line 1094: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be
formed from alpha-numeric characters or "-_."
Why this validation finishing with INVALID.Character and the description only
with INVALID? INVALID should be enough
Line 1095: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be
between {1} and {2}
Line 1091: VAR__FILTERTYPE__INTERNAL=$filterType internal
Line 1092: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform
${action}. Another power management action is already in progress.
Line 1093:
Line 1094: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be
formed from alpha-numeric characters or "-_."
Line 1095: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be
between {1} and {2}
not sure you need it, see my comment on the Business entity.
Also where do you initialize the parameters in this message?
Line 1092: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform
${action}. Another power management action is already in progress.
Line 1093:
Line 1094: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be
formed from alpha-numeric characters or "-_."
Line 1095: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be
between {1} and {2}
Line 1096: VALIDATION.ISCSI_BOND.DESCRIPTION.INVALID=Iscsi Bond description
must be formed only from alpha-numeric characters and special characters that
conform to the standard ASCII character set.
both name and description support I18N so why the message is different? I think
that the NAME.INVALID message should be the same as the description
....................................................
File packaging/dbscripts/iscsi_bonds_sp.sql
Line 20: WHERE storage_pool_id = v_storage_pool_id;
Line 21: END; $procedure$
Line 22: LANGUAGE plpgsql;
Line 23:
Line 24:
(For future patches) Worth to add also GetIscsiBondsByNameAndStoragePool so we
can validate unique bond name in DC
Line 25: Create or replace FUNCTION GetNetworksByIscsiBondId(v_iscsi_bond_id
UUID) RETURNS SETOF UUID STABLE
Line 26: AS $procedure$
Line 27: BEGIN
Line 28: RETURN QUERY SELECT iscsi_bonds_networks_map.network_id
--
To view, visit http://gerrit.ovirt.org/22951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
