Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Jsonrpc packages deployment
......................................................................
Patch Set 1:
(2 comments)
it should be in vdsm packages, I do not see any reason to put it in own plugin.
and I do not see any reason not to install these always if available without
condition from engine.
....................................................
File src/plugins/ovirt-host-deploy/vdsm-json/packages.py
Line 72: _(
Line 73: 'Cannot locate vdsm-yajsonrpc package, '
Line 74: 'possible cause is incorrect channels'
Line 75: )
Line 76: )
why do you need the two? why query twice?
also if you query you need to add these to offline packager so it return fake
success and you need to add this to ovirt-host-deploy-offline dependency
Line 77: self._enabled = True
Line 78:
Line 79: @plugin.event(
Line 80: stage=plugin.Stages.STAGE_PACKAGES,
Line 80: stage=plugin.Stages.STAGE_PACKAGES,
Line 81: condition=lambda self: self._enabled,
Line 82: )
Line 83: def _packages(self):
Line 84: self.packager.installUpdate(('vdsm-jsonrpc', 'vdsm-yajsonrpc'))
cannot be both, one should depend on the other I guess
Line 85:
Line 86: @plugin.event(
Line 87: stage=plugin.Stages.STAGE_CLOSEUP,
Line 88: condition=lambda self: (
--
To view, visit http://gerrit.ovirt.org/23089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
