Alon Bar-Lev has posted comments on this change. Change subject: packaging: Jsonrpc packages deployment ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23089/2/src/plugins/ovirt-host-deploy/vdsm/packages_json.py File src/plugins/ovirt-host-deploy/vdsm/packages_json.py: Line 60: ), Line 61: ) Line 62: def _validation(self): Line 63: if not self.packager.queryPackages(patterns=('vdsm-jsonrpc', Line 64: 'vdsm-yajsonrpc',)): > When the dependency is updated no need to have multiple lines here. enough is to query one, it is not that the other will be missing in this case. Line 65: raise RuntimeError( Line 66: _( Line 67: 'Cannot locate jsonrpc packages, ' Line 68: 'possible cause is incorrect channels' -- To view, visit http://gerrit.ovirt.org/23089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
