Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Jsonrpc packages deployment
......................................................................
Patch Set 1:
(1 comment)
you should move this into vdsm plugin, no reason to have it as its own.
add packages-json.py for now, although I think it can be merged into packages.
....................................................
File src/plugins/ovirt-host-deploy/vdsm-json/packages.py
Line 80: stage=plugin.Stages.STAGE_PACKAGES,
Line 81: condition=lambda self: self._enabled,
Line 82: )
Line 83: def _packages(self):
Line 84: self.packager.installUpdate(('vdsm-jsonrpc', 'vdsm-yajsonrpc'))
why? what is the reasoning to have one and not the other?
Line 85:
Line 86: @plugin.event(
Line 87: stage=plugin.Stages.STAGE_CLOSEUP,
Line 88: condition=lambda self: (
--
To view, visit http://gerrit.ovirt.org/23089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
