Maor Lipchuk has posted comments on this change. Change subject: engine: Setup multiple iscsi sessions with the iscsi target ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java: Line 21: String portal, Line 22: String vfsType, Line 23: String mountOptions, Line 24: NfsVersion nfsVersion, Line 25: Short nfsRetrans, do we want to add the initiator name also to the constructor? Line 26: Short nfsTimeo) { Line 27: this.connection = connection; Line 28: this.id = id; Line 29: this.iqn = iqn; Line 203: int result = 1; Line 204: result = prime * result + ((getid() == null) ? 0 : getid().hashCode()); Line 205: return result; Line 206: } Line 207: What about copy of? we will probably need to also initialize InitiatorName Line 208: public static StorageServerConnections copyOf(StorageServerConnections ssc) { Line 209: // using the constructor since all fields do not need deep copy (string Line 210: // is immutable, and storageType and nfsVersion are enums Line 211: return new StorageServerConnections(ssc.connection, http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java: Line 26: public class InterfaceDaoTest extends BaseDAOTestCase { Line 27: private static final String IP_ADDR = "10.35.110.10"; Line 28: private static final Guid VDS_ID = new Guid("afce7a39-8e8c-4819-ba9c-796d316592e6"); Line 29: private static final Guid CLUSTER_ID = new Guid("b399944a-81ab-4ec5-8266-e19ba7c3c9d1"); Line 30: private static final String TARGET_ID = "0cc146e8-e5ed-482c-8814-270bc48c297b"; Better to use FixturesTool Line 31: private static final String LABEL = "abc"; Line 32: Line 33: private InterfaceDao dao; Line 34: private VdsNetworkInterface existingVdsInterface; -- To view, visit http://gerrit.ovirt.org/23198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f6dd95dfbfc2b74ad7ba3ce2271b7c9ad94db Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
