Sergey Gotliv has posted comments on this change. Change subject: engine: Setup multiple iscsi sessions with the iscsi target ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java: Line 94: for (VdsNetworkInterface initiator : initiators) { Line 95: StorageServerConnections newConn = StorageServerConnections.copyOf(conn); Line 96: newConn.setid(Guid.newGuid().toString()); Line 97: newConn.setInitiatorName(initiator.getName()); Line 98: res.add(newConn); > shouldn't you also remove the original connection from res? No, I am using the original connection with the first found initiator Line 99: } Line 100: } Line 101: } Line 102: http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java: Line 21: String portal, Line 22: String vfsType, Line 23: String mountOptions, Line 24: NfsVersion nfsVersion, Line 25: Short nfsRetrans, > do we want to add the initiator name also to the constructor? This constructor is already too long and since initiator is not a mandatory field and adding it will require to perform changes all over the code I prefer not to do that. Line 26: Short nfsTimeo) { Line 27: this.connection = connection; Line 28: this.id = id; Line 29: this.iqn = iqn; http://gerrit.ovirt.org/#/c/23198/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java: Line 26: public class InterfaceDaoTest extends BaseDAOTestCase { Line 27: private static final String IP_ADDR = "10.35.110.10"; Line 28: private static final Guid VDS_ID = new Guid("afce7a39-8e8c-4819-ba9c-796d316592e6"); Line 29: private static final Guid CLUSTER_ID = new Guid("b399944a-81ab-4ec5-8266-e19ba7c3c9d1"); Line 30: private static final String TARGET_ID = "0cc146e8-e5ed-482c-8814-270bc48c297b"; > Better to use FixturesTool I just trying to be consistent with other parameters in this class. Line 31: private static final String LABEL = "abc"; Line 32: Line 33: private InterfaceDao dao; Line 34: private VdsNetworkInterface existingVdsInterface; Line 367: public void testGetIscsiInitiatorsByHostIdAndStorageTargetId() { Line 368: List<VdsNetworkInterface> interfaces = Line 369: dao.getIscsiInitiatorsByHostIdAndStorageTargetId(VDS_ID, TARGET_ID); Line 370: Line 371: assertNotNull(interfaces); > you're missing the Correct :-). Line 372: for (VdsNetworkInterface nic : interfaces) { Line 373: assertEquals(VDS_ID, nic.getVdsId()); Line 374: } Line 375: } -- To view, visit http://gerrit.ovirt.org/23198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f6dd95dfbfc2b74ad7ba3ce2271b7c9ad94db Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
