Martin Peřina has posted comments on this change. Change subject: engine: Notify host is Up only when InitVdsOnUp succeeded ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23073/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 892: } else if (isVdsUpOrGoingToMaintenance || _vds.getStatus() == VDSStatus.Error) { Line 893: return; Line 894: } Line 895: // show status UP in audit only when InitVdsOnUpCommand finished successfully Line 896: if (_vds.getStatus() != VDSStatus.Up) { > Martin, why can't we just have the audit log you added at InitiVdsOnUp, and AFAIK IniVdsOnUp is called only after host status changed to Up, but this method is called during refreshVds, so here are logged all status changes except Up, which I moved into InitVdsOnUp Line 897: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); Line 898: logable.addCustomValue("VdsStatus", _vds.getStatus().toString()); Line 899: auditLog(logable, AuditLogType.VDS_DETECTED); Line 900: } -- To view, visit http://gerrit.ovirt.org/23073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0fab61b10bea280ca81eca74f2912b61bd58876 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
