Martin Peřina has posted comments on this change. Change subject: engine: Notify host is Up only when InitVdsOnUp succeeded ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23073/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 133: setSucceeded(initSucceeded); Line 134: Line 135: if (getSucceeded()) { Line 136: AuditLogableBase logable = new AuditLogableBase(getVds().getId()); Line 137: logable.addCustomValue("VdsStatus", getVds().getStatus().toString()); > See my comment in VdsUpdateRunTimeInfo Done Line 138: AuditLogDirector.log(logable, AuditLogType.VDS_DETECTED); Line 139: } Line 140: } Line 141: http://gerrit.ovirt.org/#/c/23073/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 894: } Line 895: // show status UP in audit only when InitVdsOnUpCommand finished successfully Line 896: if (_vds.getStatus() != VDSStatus.Up) { Line 897: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); Line 898: logable.addCustomValue("VdsStatus", _vds.getStatus().toString()); > 'VdsStatus' value was already there, but I can change it to 'HostStatus' an Done Line 899: auditLog(logable, AuditLogType.VDS_DETECTED); Line 900: } Line 901: } Line 902: -- To view, visit http://gerrit.ovirt.org/23073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0fab61b10bea280ca81eca74f2912b61bd58876 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
