Liron Ar has posted comments on this change. Change subject: core: AddDiskCommand - add option to leave disk as illegal on failure ......................................................................
Patch Set 11: Sergey, When we add a disk and fail, the general behavior should be an inspectation of the received error - if there's a chance that there was any change on the storage, the disk should remain in the engine to reflect that (for example, if we attempted to create 50gb disk and got network error but a task was created on vdsm side, should the disk be removed?) that's a general behavior change, in this patch i introduce a prerparation to this change. In a following patch, when there's no OVF disk on domain the engine attempts to create one automatically as part of the ovf on any domain feature, in case of failed creation, I don't want the engine to attempt to create disks endlessly, so currently the use is for that case, on later changes we can extend the useage and leave the disk on more cases. -- To view, visit http://gerrit.ovirt.org/23462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
