Liron Ar has posted comments on this change. Change subject: core: AddDiskCommand - add option to leave disk as illegal on failure ......................................................................
Patch Set 11: AddDiskCommand is used for all the usecases. The fact that the disk we add is an ovf disk is not relevant as the AddDisk command isn't aware to that that the disk will be used for ovfs, it is relevant for the command to "know" that on failed execution is shouldn't just remove the disk from the db - how do you suggest to pass it other than the paremters? why passing it within the parameters is problematic in your opinion? in my opinion thats exactly something that we'll want to pass in the parameters, commands are executed also internally, not only by the user. -- To view, visit http://gerrit.ovirt.org/23462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
