Sergey Gotliv has posted comments on this change. Change subject: core: AddDiskCommand - add option to leave disk as illegal on failure ......................................................................
Patch Set 11: Today AddDisk distinguishs between Image and Direct Lun, actually the major part of this command is about distinguish between them. You can't just say that this command is not aware of the disk type today. I don't know about the OVF disk though so I am trying to understand the logic, for example, if the OVF disk is another type of the disk like image and lun maybe (I am raising the question...) its reasonable to base this new logic on type of the disk, because the only place that really needs that is OVF. But I am not insist, if you considered other options either and came to conclusion that this approach is the best, its fine with me. -- To view, visit http://gerrit.ovirt.org/23462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
