Yedidyah Bar David has posted comments on this change. Change subject: db: cleanup: trivial issues and bashism removal ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/24881/5/packaging/dbscripts/dbfunctions.sh File packaging/dbscripts/dbfunctions.sh: Line 18: Line 19: echo "${command}" > "${filename}" Line 20: Line 21: execute_file "${filename}" "${dbname}" "${dbhost}" "${dbport}" Line 22: ) || exit $? Really exit? Previous code didn't. If you do exit, perhaps also echo something. Line 23: } Line 24: Line 25: # $1 - the file to execute Line 26: # $2 - the database to use Line 95: CMD="select * from generate_drop_all_user_types_syntax();" Line 96: execute_command "${CMD}" "${DATABASE}" "${SERVERNAME}" "${PORT}" Line 97: } > "${file}" Line 98: execute_file "${file}" "${DATABASE}" "${SERVERNAME}" "${PORT}" > /dev/null Line 99: ) || exit $? exit? Line 100: } Line 101: Line 102: #drops views before upgrade or refresh operations Line 103: drop_views() { Line 123: Line 124: CMD="select * from generate_drop_all_functions_syntax();" Line 125: execute_command "$CMD" "${DATABASE}" "${SERVERNAME}" "${PORT}" > "${drop_all_functions}" Line 126: execute_file "${drop_all_functions}" "${DATABASE}" "${SERVERNAME}" "${PORT}" > /dev/null Line 127: ) || exit $? exit? Line 128: Line 129: # recreate generic functions Line 130: execute_file "create_functions.sql" "${DATABASE}" "${SERVERNAME}" "${PORT}" > /dev/null Line 131: } -- To view, visit http://gerrit.ovirt.org/24881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
