Eli Mesika has posted comments on this change. Change subject: db: cleanup: trivial issues and bashism removal ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25126/1/packaging/dbscripts/refreshStoredProcedures.sh File packaging/dbscripts/refreshStoredProcedures.sh: Line 29: OPTARG Aren't all those $OPTARG should be "$OPTARG" ? http://gerrit.ovirt.org/#/c/25126/1/packaging/dbscripts/unlock_entity.sh File packaging/dbscripts/unlock_entity.sh: Line 14: TWS Line 20: -r - Recursive, unlocks all disks under the selected vm/template. Line 21: -q - Query db and display a list of the locked entites. Line 22: -v - Turn on verbosity (WARNING: lots of output) Line 23: -h - This help text. Line 24: ENTITIES - The list of object names in case of vm/template, UUIDs in case of a disk TWS Line 25: Line 26: __EOF__ Line 27: } Line 28: -- To view, visit http://gerrit.ovirt.org/25126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
