Sandro Bonazzola has posted comments on this change. Change subject: db: cleanup: trivial issues and bashism removal ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24881/5/packaging/dbscripts/dbfunctions.sh File packaging/dbscripts/dbfunctions.sh: Line 135: echo "Creating stored procedures..." Line 136: local sql Line 137: for sql in $(ls *sp.sql | sort); do Line 138: echo "Creating stored procedures from ${sql}..." Line 139: execute_file "${sql}" "${DATABASE}" "${SERVERNAME}" "${PORT}" > /dev/null doesn't execute_file implicitly exit? So only first one will be executed right? Line 140: done Line 141: execute_file "common_sp.sql" "${DATABASE}" "${SERVERNAME}" "${PORT}" > /dev/null Line 142: } Line 143: -- To view, visit http://gerrit.ovirt.org/24881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
