Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: added jrs pro edition deploy steps
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/25030/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py:

Line 934:                         xml.xpath.xpathEval('/folder')[0].addChild(
Line 935:                             addition.getRootElement()
Line 936:                         )
Line 937:                     finally:
Line 938:                         # do not free, cause segmentation fault
I guess you've a segmentation fault freeing the doc because you're holding 
reference to addition root element.

I think you can solve this by duplicating root element and adding the copy 
instead of the original element.
Line 939:                         #addition.freeDoc()
Line 940:                         pass
Line 941: 
Line 942:         self._oreportsutil.jsimport(everything)


-- 
To view, visit http://gerrit.ovirt.org/25030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to