Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added jrs pro edition deploy steps ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/25030/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 580 Line 581 Line 582 Line 583 Line 584 > This is a JRS export path. Not a physical path, so it will always be with s there is no problem with that. os.path.join has nothing to do with physicals... as far as I can see // is interpreted as / so you are good even with os.path.join('/a', '/b') Line 636: # to be a new absulote path, had to concat the path strings. Line 637: # Line 638: self._dwhdatasource = os.path.join( Line 639: dwhdatasourceexport, Line 640: 'resources' + > It is a path join with the relative path concat to it. Read the above comme should not be an issue, check it out, tell me where the problem is. Line 641: self._reportsProRelativePath, Line 642: 'reports_resources', Line 643: 'JDBC', Line 644: 'data_sources', -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
