Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added jrs pro edition deploy steps ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/25030/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 580 Line 581 Line 582 Line 583 Line 584 I do not see previous replies this should be os.path.join Line 580: Line 581: if ( Line 582: self.environment[oreportscons.JasperEnv.JASPER_NAME] == 'pro' Line 583: ): Line 584: self._reportsProRelativePath = '/organizations/organization_1' remove '/' at prefix, it is relative. Line 585: Line 586: everything = self._oreportsutil.jsexport( Line 587: what='everything', Line 588: args=( Line 636: # to be a new absulote path, had to concat the path strings. Line 637: # Line 638: self._dwhdatasource = os.path.join( Line 639: dwhdatasourceexport, Line 640: 'resources' + this should be os.path.join Line 641: self._reportsProRelativePath, Line 642: 'reports_resources', Line 643: 'JDBC', Line 644: 'data_sources', -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
