Allon Mureinik has uploaded a new change for review.

Change subject: core: Updating roles.is_inheritable properly
......................................................................

core: Updating roles.is_inheritable properly

This patch contains the logic for updating roles.is_inheritable - if a
role contains at least one inheritable action group then it too is
ingeritable.

This patch contains all the (relevant) places roles are modified:
1. An upgarade script to initialize the property properly
2. When a new action group is attached to a role
3. When an action group is detached from a role
4. When a role is created without action groups
5. When a role is created with action groups

Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07
Signed-off-by: Allon Mureinik <[email protected]>
---
A 
backend/manager/dbscripts/upgrade/03_01_1100_update_role_inheritable_column.sql
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractRolesCommandTestBase.java
A 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommandTest.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommandTest.java
A 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommandTest.java
10 files changed, 263 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/4607/1
--
To view, visit http://gerrit.ovirt.org/4607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to