Roy Golan has posted comments on this change. Change subject: core: Updating roles.is_inheritable properly ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java Line 102: role.setInheritable(false); this concept is really not clear to me. why both roles and action groups have isInheritable? if the logic is being done on the roles than we dont need a setter only a getter, which will fetch the inner values. may be I'm missing something. also the naming is not descriptive. what is a role which is inheritable? who can inherit it? .................................................... Commit Message Line 11: ingeritable. typo -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
