Allon Mureinik has posted comments on this change. Change subject: core: Updating roles.is_inheritable properly ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java Line 102: role.setInheritable(false); Regarding the logic: ActionGroups have no database representation - only the ActionGroup enum in the java side. Since this property is needed in the database level, it must be set on the role too. Since there is no way to caculate it directly in the database (as noted - ActioNGroups have no representation in the database), it must be calculated by the engine and persisted in the database - hence the setter. Regarding the naming convention: The idea was that certain roles grant view permissions not only on the object they are given on, but also on the objects under it. E.g., UPDATE VM on a DATA CENTER will allow you to see all the VMs inside it, since you can also update them. CREATE VM on a DATA CENTER, on the other hand, will not - you can only create new vms. There is no reason you'd be able to see the other VMs. If you have a better suggestion for the name, I'd be glad to hear/use it. .................................................... Commit Message Line 11: ingeritable. will fix and update a new patch, thanks. -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
