Lior Vernia has posted comments on this change. Change subject: webadmin: Fix the alignment of power management checkbox ......................................................................
Patch Set 1: It is usually considered better practice to do as much of the styling as possible in the .ui.xml file. We tend to add style in the Java code only when the widgets are created dynamically during the lifetime of the dialog or when it's an inner widget (inside another widget) and as such isn't accessible in the .ui.xml file. Just my two cents... -- To view, visit http://gerrit.ovirt.org/25177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850b88e42c6d421a5bded9964e9361f4f993a4d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
