Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix the alignment of power management checkbox ......................................................................
Patch Set 1: I agree with Lior, using <ui:style> in *.ui.xml templates should always be the preferred way of styling widgets (excluding ones that are created dynamically after UiBinder.createAndBindUi invocation). If you look closely, also AbstractValidatedWidgetWithLabel.getContentWidgetContainer method is public; callers typically do getContentWidgetContainer().getElement() and modify styles of the DOM element. The exact same story like AbstractValidatedWidgetWithLabel.getLabelElement method, which is public as of this patch. In general, the optimal solution would be to have custom UiBinder element parsers. A custom element parser could, for example, parse extra "addLabelStyleNames" attribute, in addition to existing ones like "addStyleNames". Unfortunately, GWT doesn't plan to support custom element parsers: http://code.google.com/p/google-web-toolkit/issues/detail?id=4461 (Sure, we could consider using @UiConstructor annotation but this is far from optimal/flexible solution, so I don't consider this as viable alternative.) -- To view, visit http://gerrit.ovirt.org/25177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850b88e42c6d421a5bded9964e9361f4f993a4d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
