Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Fix the alignment of power management checkbox
......................................................................
Patch Set 1:
After discussing with Alex, turns out I completely forgot that custom
attributes implicitly yield setter method calls in UiBinder templates.
@Martin, please give following one more try:
HostPopupView.ui.xml
<ge:EntityModelCheckBoxEditor labelStyleNames="{style.policyOverrideLabel}"
ui:field="disableAutomaticPowerManagementEditor"/>
AbstractValidatedWidgetWithLabel.java
public void setLabelStyleNames(String styleNames) {
for (String name : styleNames.split("[,\\s]+")) { //$NON-NLS-1$
labelElement.addClassName(name);
}
}
This way, no changes are necessary in HostPopupView.java +
AbstractValidatedWidgetWithLabel.java (getLabelElement method can remain
protected).
--
To view, visit http://gerrit.ovirt.org/25177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I850b88e42c6d421a5bded9964e9361f4f993a4d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
