Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2154: <xs:element name="ports_mirroring" type="PortsMirroring"
minOccurs="0" maxOccurs="1"/>
please use /ref=/ here
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 317: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.mac.address: 'xs:string', nic.interface:
'xs:string', nic.port_mirroring: 'xs:boolean'}
please update according to last change in port_mirroring modelling
Line 340: optionalArguments: {nic.mac.address: 'xs:string',
nic.interface: 'xs:string', nic.port_mirroring: 'xs:boolean'}
please update according to last change in port_mirroring modelling
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 44:
model.getPortsMirroring().getPortMirroring().getNetwork().getName().equals(entity.getNetworkName()));
potential NPE on .getNetwork().getName(), you have also to check if network is
set before using it
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java
Line 31: //TODO: is that test ok?
you should compare network/s inside
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
