Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2157: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
this i not what you have stated in commit message, where is collection
of ports_mirroring ? - we won't be able to add it later.
using this modelling you can have only one network mirrored for one nic
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
1. ports_mirroring.port_mirroring.network.id (in collection)
2. why did you removed the mac.address and interface?
Line 348: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
1. ports_mirroring.port_mirroring.network.id (in collection)
2. why did you removed the mac.address and interface?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 57: throw new WebApplicationException(response);
shouldn't this logic be in backend?, this is pure can_do_action,
doing it in client is wrong + we won't be able to localize the error.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 74: }
same, this logic should be moved to BE
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 71: net.setName(entity.getNetworkName());
by commit message here should be id and not name
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
