Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 15: I would prefer that you didn't submit this
(1 inline comment)
....................................................
Commit Message
Line 21:
this is not the design we agreed on at the thread, it was suppose to be:
<nics>
<nic>
...
<network href="/api/networks/{network-id}" id="{network-id}"/>
<port-mirroring>
<network href="/api/networks/{network-id}" id="{network-id}"/>
....
</port mirroring>
</nic>
</nics>
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
