Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: inform about available additions ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/24865/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-02-21 17:23:20 +0100 Line 6: Line 7: packaging: setup: inform about available additions Line 8: Line 9: Inform the user about the avialbility of ovirt-engine-reports > availability Done Line 10: and ovirt-engine-dwh. Line 11: Line 12: Change-Id: I236e24c7b5d0902e9e6fe9390679abfc661f2c31 http://gerrit.ovirt.org/#/c/24865/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py: Line 64: if env_key.startswith(self._checks[key]): Line 65: self._installed.append(env_key) Line 66: for key in self._legacy: Line 67: if os.path.exists(self._legacy[key]): Line 68: self._need_update.append(key) > this can be done at closeup... no need here nor to add anything to object s Done Line 69: Line 70: @plugin.event( Line 71: stage=plugin.Stages.STAGE_CLOSEUP, Line 72: before=( Line 78: condition=lambda self: len(self._installed) < len(self._checks), Line 79: ) Line 80: def _closeup(self): Line 81: available = set(self._checks.keys()) - ( Line 82: set(self._installed).union(set(self._need_update)) > use set operators? Done Line 83: ) Line 84: if available: Line 85: self.dialog.note( Line 86: text=_( Line 94: engine=osetupcons.Const.ENGINE_PACKAGE_NAME, Line 95: package=package, Line 96: ) Line 97: ) Line 98: if self._need_update: > if available do not check update? Done Line 99: self.dialog.note( Line 100: text=_( Line 101: 'You should now update the following packages:\n' Line 102: ) Line 111: self.dialog.note( Line 112: text=_( Line 113: 'And run again this Setup.' Line 114: ) Line 115: ) > add this above: Done Line 116: Line 117: -- To view, visit http://gerrit.ovirt.org/24865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236e24c7b5d0902e9e6fe9390679abfc661f2c31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
