Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: inform about available additions ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/24865/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py: Line 67: installed = [] Line 68: need_update = [] Line 69: for key in self._checks: Line 70: if os.path.exists(self._checks[key]): Line 71: installed.append(key) > Had to drop environment checks because of post-install providing keys also which is fine... as we need to present this once to user. Line 72: for key in self._legacy: Line 73: if os.path.exists(self._legacy[key]): Line 74: need_update.append(key) Line 75: available = set(self._checks.keys()) - ( Line 70: if os.path.exists(self._checks[key]): Line 71: installed.append(key) Line 72: for key in self._legacy: Line 73: if os.path.exists(self._legacy[key]): Line 74: need_update.append(key) ? [key for key, value in self._legacy.items() if os.path.exists(value)] Line 75: available = set(self._checks.keys()) - ( Line 76: set(installed) + set(need_update) Line 77: ) Line 78: if available: Line 85: for package in available: Line 86: self.dialog.note( Line 87: ' - {engine}-{package}'.format( Line 88: engine=self.environment[ Line 89: osetupcons.RPMDistroEnv.ENGINE_SETUP_PACKAGES can't this contain more than one? Line 90: ], Line 91: package=package, Line 92: ) Line 93: ) -- To view, visit http://gerrit.ovirt.org/24865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236e24c7b5d0902e9e6fe9390679abfc661f2c31 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
