Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: inform about available additions ......................................................................
Patch Set 5: (2 comments) the only major comment is the None consideration, the other is just to consider reducing logic. http://gerrit.ovirt.org/#/c/24865/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/optionals.py: Line 104: for key, content in self.environment.items() Line 105: if key.startswith( Line 106: osetupcons.RPMDistroEnv.OPTIONAL_INSTALL_PACKAGES_PREFIX Line 107: ) Line 108: ]: please check if checkfile is not None so we can disable behaviour. Line 109: packages.add(package) Line 110: if os.path.exists(checkfile): Line 111: installed.add(package) Line 112: Line 134: if available: Line 135: self.dialog.note( Line 136: text=_( Line 137: 'You may also be interested in installing the following ' Line 138: 'packages which require additional resources:\n' you do not need trailing \n I think that we can print the interesting package list in any case, not check anything... and only for legacy add special instructions. why not? these interesting packages are always of interest... Line 139: ) Line 140: ) Line 141: for package in available: Line 142: self.dialog.note( -- To view, visit http://gerrit.ovirt.org/24865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I236e24c7b5d0902e9e6fe9390679abfc661f2c31 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
