Yaniv Bronhaim has posted comments on this change. Change subject: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26061/4//COMMIT_MSG Commit Message: Line 7: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version Line 8: Line 9: If Engine sees itself in the supportedENGINES of a Vdsm of an unknown version, Line 10: and that Vdsm has the relevant clusterLevel, Line 11: Engine should believe it and take it into the cluster. the patch also removes SupportedVDSMVersions, i think it worth to mention Line 12: Line 13: Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Line 14: Bug-Url: https://bugzilla.redhat.com/1077110 http://gerrit.ovirt.org/#/c/26061/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 58: } Line 59: Line 60: // If vdsm doesn't support the engine's version (engine's version is not included Line 61: // vdsm supprtedEngineVersions list) we move on and check if engine Line 62: // and cluster supports the specific vdsm version. which is sufficient change also the comment please - we don't check if engine supports vdsm version anymore, only cluster capability Line 63: if (!isEngineSupportedByVdsm) { Line 64: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, Line 65: partialVdcVersion.toString(), Line 66: vdsmVersion.toString()); Line 61: // vdsm supprtedEngineVersions list) we move on and check if engine Line 62: // and cluster supports the specific vdsm version. which is sufficient Line 63: if (!isEngineSupportedByVdsm) { Line 64: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, Line 65: partialVdcVersion.toString(), i think it worth changing also VERSION_INCOMPATIBLE_WITH_CLUSTER to something more related - "vdsm $version$ capabilities don't support engine $version$", and the constant respectively Line 66: vdsmVersion.toString()); Line 67: } Line 68: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { Line 69: reportNonOperationReason(NonOperationalReason.CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER, -- To view, visit http://gerrit.ovirt.org/26061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
