Yaniv Bronhaim has posted comments on this change.

Change subject: core: Host's Compatibility Version doesn't match the Cluster's 
Compatibility Version
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26061/6/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties:

Line 368: VDS_VERSION_NOT_SUPPORTED_FOR_CLUSTER
not sure about that constant and if we still require it (being used only in 
SetNonOperationalVdsCommand),
but you need to modify - VERSION_INCOMPATIBLE_WITH_CLUSTER which you use. and i 
would change the name of it also to something more related, like 
VDSM_VERSION_INCOMPATIBLE_WITH_ENGINE_VERSION


-- 
To view, visit http://gerrit.ovirt.org/26061
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to