Alon Bar-Lev has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the new extensions API ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/26443/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 22: try { Line 23: if (input.get(Base.InvokeKeys.COMMAND).equals(Base.InvokeCommands.INITIALIZE)) { Line 24: doInit(input, output); Line 25: } Line 26: if (input.get(Base.InvokeKeys.COMMAND).equals(Authn.InvokeCommands.AUTHENTICATE_CREDENTIALS)) { else if? Line 27: doAuthenticate(input, output); Line 28: } Line 29: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.SUCCESS); Line 30: } catch (Exception ex) { Line 24: doInit(input, output); Line 25: } Line 26: if (input.get(Base.InvokeKeys.COMMAND).equals(Authn.InvokeCommands.AUTHENTICATE_CREDENTIALS)) { Line 27: doAuthenticate(input, output); Line 28: } you need to add else and return unsupported. Line 29: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.SUCCESS); Line 30: } catch (Exception ex) { Line 31: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.FAILED); Line 32: output.mput(Base.InvokeKeys.MESSAGE, ex.getMessage()); -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
