Yair Zaslavsky has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the new extensions API ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/26443/9/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 26: } else if (input.get(Base.InvokeKeys.COMMAND).equals(Authn.InvokeCommands.AUTHENTICATE_CREDENTIALS)) { Line 27: doAuthenticate(input, output); Line 28: } else { Line 29: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.UNSUPPORTED); Line 30: } > consider: Done Line 31: } catch (Exception ex) { Line 32: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.FAILED). Line 33: mput(Base.InvokeKeys.MESSAGE, ex.getMessage()); Line 34: } Line 48: private void doInit(ExtMap input, ExtMap output) { Line 49: context = input.<ExtMap> get(Base.InvokeKeys.CONTEXT); Line 50: context.<List<String>> get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS).add("config.authn.user.password"); Line 51: context.mput(Base.ContextKeys.AUTHOR, "The oVirt Project"). Line 52: mput(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS, "config.authn.user.password"). > remove ^ ? Done Line 53: mput(Base.ContextKeys.EXTENSION_NAME, "Internal Authentication (Built-in"). Line 54: mput(Base.ContextKeys.LICENSE, "ASL 2.0"). Line 55: mput(Base.ContextKeys.HOME_URL, "http://www.ovirt.org";). Line 56: mput(Base.ContextKeys.VERSION, "N/A"). Line 57: mput(Authn.ContextKeys.CAPABILITIES, Authn.Capabilities.AUTHENTICATE_PASSWORD); Line 58: Properties config = context.<Properties> get(Base.ContextKeys.CONFIGURATION); Line 59: adminUser = config.getProperty("config.authn.user.name"); Line 60: adminPassword = config.getProperty("config.authn.user.password"); Line 61: output.mput(Base.InvokeKeys.RESULT, Base.InvokeResult.SUCCESS); > why here? I would have put it at the invoke so that RESULT is handled at on Done Line 62: } Line 63: -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
