Yair Zaslavsky has posted comments on this change. Change subject: aaa: InternalAuthenticator should use the new extensions API ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/26443/10/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorProxy.java: Line 23: Line 24: @Override Line 25: @Deprecated Line 26: public void authenticate(String user, String password) { Line 27: ExtMap inputMap = new ExtMap().mput( > you can remove the inputMap temp variable. Done Line 28: Base.InvokeKeys.COMMAND, Authn.InvokeCommands.AUTHENTICATE_CREDENTIALS Line 29: ).mput( Line 30: Authn.InvokeKeys.USER, user Line 31: ).mput( http://gerrit.ovirt.org/#/c/26443/10/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthenticator.java: Line 44: Line 45: private void doInit(ExtMap input, ExtMap output) { Line 46: context = input.<ExtMap> get(Base.InvokeKeys.CONTEXT); Line 47: context.mput(Base.ContextKeys.AUTHOR, "The oVirt Project"). Line 48: mput(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS, "config.authn.user.password"). > you removed the wrong lines... please do not replace the list, append. Done Line 49: mput(Base.ContextKeys.EXTENSION_NAME, "Internal Authentication (Built-in"). Line 50: mput(Base.ContextKeys.LICENSE, "ASL 2.0"). Line 51: mput(Base.ContextKeys.HOME_URL, "http://www.ovirt.org";). Line 52: mput(Base.ContextKeys.VERSION, "N/A"). -- To view, visit http://gerrit.ovirt.org/26443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60f7b7f50617bff9f4872dc79f14fb016c9d72d3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
