Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 25: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.mac.address: 'xs:string', nic.interface:
'xs:string', nic.port_mirroring--COLLECTION: {port_mirroring.network.name:
'xs:string'}}
you forgot changing it to id
Line 348: optionalArguments: {nic.mac.address: 'xs:string',
nic.interface: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
you forgot changing it to id
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 41: }
Shahar, this is backend->user mapping, you don't need all this /if/ conditions
on /model/ (client resource),
instead you need to check if P.M enabled in /network/ obj. and if yes
create PortMirroring in /model/ (client resource).
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 31: public class BackendVmNicsResource
you missing same treatment of /set network_id/ as you did for single resource,
see BackendNicsResource.java:55
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 72: if (entity.isPortMirroring()) {
you don't need this mapping as P.M will be set in populate() of resource and
collection
(at least in this version)
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
